View Single Post
Old April 20th, 2021   #8
peternewman
Junior Member
 
Join Date: Oct 2018
Location: London
Posts: 11
Default

I also mocked up your original followspot personality, with raw data:
Code:
{'slot_label_id': 1, 'slot_offset': 0, 'slot_type': 0},
{'slot_label_id': 1, 'slot_offset': 1, 'slot_type': 1},
{'slot_label_id': 2, 'slot_offset': 2, 'slot_type': 0},
{'slot_label_id': 2, 'slot_offset': 3, 'slot_type': 1},
{'slot_label_id': 1028, 'slot_offset': 4, 'slot_type': 2},
{'slot_label_id': 1028, 'slot_offset': 5, 'slot_type': 3},
{'slot_label_id': 1283, 'slot_offset': 6, 'slot_type': 2},
{'slot_label_id': 1282, 'slot_offset': 7, 'slot_type': 4}

Pretty printed:
Code:
Slot offset 0: Primary, intensity
Slot offset 1: Secondary, fine control for slot 1
Slot offset 2: Primary, intensity master
Slot offset 3: Secondary, fine control for slot 2
Slot offset 4: Secondary, timing control for slot 1028
Slot offset 5: Secondary, speed control for slot 1028
Slot offset 6: Secondary, timing control for slot 1283
Slot offset 7: Secondary, mode control for slot 1282
Hopefully it's fairly clear to see what's wrong there, but our RDM tests catch it too:
Code:
------------------- Warnings --------------------
Slot 1 is of type secondary and references slot 1 which isn't a primary slot
Slot 4 is of type secondary and references an unknown slot 1028
Slot 5 is of type secondary and references an unknown slot 1028
Slot 6 is of type secondary and references an unknown slot 1283
Slot 7 is of type secondary and references an unknown slot 1282

Full disclosure, I've only just added the warning about slot 1 and that will go into our primary branch for a future release once #1720 is merged, but the other test already existed.
peternewman is offline   Reply With Quote